Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving SchemaView() calls from global space to parts where necessary. #324

Merged
merged 16 commits into from
Nov 23, 2022

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Nov 9, 2022

Followup on #323 . Fixes #322

sssom/constants.py Outdated Show resolved Hide resolved
sssom/constants.py Outdated Show resolved Hide resolved
sssom/constants.py Outdated Show resolved Hide resolved
@matentzn
Copy link
Collaborator

lets go over this during next call. Some small qs but generally looks good!

tox.ini Show resolved Hide resolved
@hrshdhgd hrshdhgd merged commit e9ac84d into master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constants.py should not invoke schemaview
3 participants