Check attribute exists using hasattr() and anchor SQLAlchemy version.
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrshdhgd
changed the title
hasattr()hasattr() and anchor SQLAlchemy version.
matentzn
reviewed
Feb 2, 2023
cmungall
reviewed
Feb 2, 2023
2 tasks
matentzn
reviewed
Feb 4, 2023
matentzn
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSSOMSchemaView.instance if SSSOMSchemaView.instance else SSSOMSchemaView()=> SSSOMSchemaView.instance if hasattr(SSSOMSchemaView,"instance") else SSSOMSchemaView() fixes SSSOM code broken #340SQLAlchemy's latest version (v2.x.x) is causing errors in legacy code. Need to update code to be v2.x.x compliant. For now anchoring it to prior version v1.4.46SQLAlchemyis a dependency ofpandasqland there is ticket for this.setup.pyfromflake8check intoxdue to this issue experiencedlexmatchnext steps: separate exact matches monarch-initiative/mondo-ingest#129 (comment)