Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy latest version creating incompatibility errors. #391

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jul 14, 2023

I switched sssom-py to using any version of python >= 3.8 but < 4.0.0 for now, (it was <3.12 earlier). Due to this, poetry complained about scipy having conflicting python version compatibility.

Solution poetry add scipy="*": What this does is finds a compatible version of scipy and installs it. This will fix some headache in the future.

For now this will fix the following problem pin ODK:

The current project's Python requirement (>=3.8,<4.0.0) is not compatible with some of the required packages Python requirement:
  - sssom requires Python >=3.8,<3.12, so it will not be satisfied for Python >=3.12,<4.0.0

Because sssom (0.3.35) requires Python >=3.8,<3.12
 and no versions of sssom match >0.3.35,<0.4.0, sssom is forbidden.
So, because test depends on sssom (^0.3.35), version solving failed.

@@ -11,7 +11,7 @@ license = "MIT"
readme = "README.md"

[tool.poetry.dependencies]
python = ">=3.8,<3.12"
python = "^3.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this allow 3.12?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in other words, why not >=3.8,<4.0.0)

Copy link
Contributor Author

@hrshdhgd hrshdhgd Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will allow 3.12.x. This means exactly that >=3.8, <4.0.0

@matentzn
Copy link
Collaborator

See my question before merging, else LGTM

@hrshdhgd hrshdhgd merged commit dc13f36 into master Jul 16, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the dependency-version-change branch July 16, 2023 13:42
@cmungall
Copy link
Collaborator

cmungall commented Jul 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants