-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scipy
latest version creating incompatibility errors.
#391
Conversation
@@ -11,7 +11,7 @@ license = "MIT" | |||
readme = "README.md" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.8,<3.12" | |||
python = "^3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this allow 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(in other words, why not >=3.8,<4.0.0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it will allow 3.12.x. This means exactly that >=3.8, <4.0.0
See my question before merging, else LGTM |
Why not fix all the other `^` dependencies to '>='. As a core library that
is reused in multiple other projects, sssom-py simply has to be less
opinionated about versions.
Do we even need scipy as a core dependency?
I think I am responsible for introducing this:
https://github.com/mapping-commons/sssom-py/blame/master/src/sssom/cli.py#L488C32-L488C32
Back when sssom-py was a bit more experimental. But if people are really
using this non-core function perhaps this could be an extra.
We really need to be making our core python libraries more lightweight.
Note every design decision from 3+ years ago is set in stone. We can start
moving out non-core functionality into separate packages, plugins, or make
the dependency an extra.
…On Fri, Jul 14, 2023 at 1:51 PM Harshad ***@***.***> wrote:
I switched sssom-py to using any version of python >= 3.8 but < 4.0.0
(for now). Due to this, poetry complained abut spicy having conflicting
python version compatibility.
Solution poetry add scipy="*": What this does is finds a compatible
version of scipy and installs it. This will fix some headache in the
future.
------------------------------
You can view, comment on, or merge this pull request online at:
#391
Commit Summary
- 25a0470
<25a0470>
scipy latest version creating incompatibility errors.
File Changes
(2 files <https://github.com/mapping-commons/sssom-py/pull/391/files>)
- *M* poetry.lock
<https://github.com/mapping-commons/sssom-py/pull/391/files#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89>
(790)
- *M* pyproject.toml
<https://github.com/mapping-commons/sssom-py/pull/391/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711>
(4)
Patch Links:
- https://github.com/mapping-commons/sssom-py/pull/391.patch
- https://github.com/mapping-commons/sssom-py/pull/391.diff
—
Reply to this email directly, view it on GitHub
<#391>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOMLPHMXCPF4RBKBRTTXQGWLXANCNFSM6AAAAAA2KZDQS4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I switched
sssom-py
to using any version of python >= 3.8 but < 4.0.0 for now, (it was <3.12 earlier). Due to this, poetry complained aboutscipy
having conflicting python version compatibility.Solution
poetry add scipy="*"
: What this does is finds a compatible version ofscipy
and installs it. This will fix some headache in the future.For now this will fix the following problem pin ODK: