Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove poetry lock #399

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Remove poetry lock #399

merged 2 commits into from
Jul 25, 2023

Conversation

hrshdhgd
Copy link
Contributor

Reasoning:

For some reason GitHub environments do not like the latest version of poetry (v1.5.1 as of now). The only version that works without problems is v1.3.2. Hence qc.yml is pinned to that version. By adding poetry.lock to .gitignore, GitHub generates its own poetry.lock in its environment and there won't be errors while installing dependencies in the GitHub environment.

This is the solution proposed via this PR.

@hrshdhgd hrshdhgd marked this pull request as ready for review July 25, 2023 19:11
@hrshdhgd hrshdhgd requested review from matentzn and removed request for matentzn July 25, 2023 19:37
@hrshdhgd hrshdhgd merged commit dbb490d into master Jul 25, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the remove-poetry-lock branch July 25, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant