Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to use subject_category and object_category? #256

Closed
saubin78 opened this issue Feb 10, 2023 · 3 comments
Closed

how to use subject_category and object_category? #256

saubin78 opened this issue Feb 10, 2023 · 3 comments
Assignees
@matentzn

Comments

@saubin78
Copy link

Hi,
the documentation for both those metadata elements lacks clarity :

The conceptual category to which the subject belongs to. This can be a string denoting the category or a term from a controlled vocabulary.

what do you mean by category? Is it a semantic one, like "disease", "material", "activity", etc.? If not, what?
What's their purpose?
matentzn added a commit that referenced this issue Feb 10, 2023
@matentzn
Improve documentation for subject and object categories
918e696 
Solves #256
@matentzn matentzn mentioned this issue Feb 10, 2023
Merged
4 tasks
@matentzn
Copy link
Collaborator

@saubin78 Thank you, as always, for your awesome feedback. Can you check if this is making it clearer: #257

Please be strict, this should really be improved significantly.

@matentzn
Copy link
Collaborator

@saubin78 did you get a chance to look at #257 ? Is this ok for now?

@matentzn matentzn self-assigned this Feb 16, 2023
matentzn added a commit that referenced this issue Feb 17, 2023
@matentzn
Improve documentation for subject and object categories (#257)
d1028f5 
* Improve documentation for subject and object categories

Solves #256

* Update sssom_schema.yaml
@matentzn
Copy link
Collaborator

matentzn commented Mar 18, 2023 •
edited

Fixed and documented in release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matentzn matentzn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matentzn @saubin78