Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OWL files. Possibly fixes #102 #140

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Include OWL files. Possibly fixes #102 #140

merged 2 commits into from
Feb 11, 2022

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Feb 11, 2022

See

Note if we merge this and make a w3id PURL for it we should probably include more inline caveats, see:

https://linkml.io/linkml/generators/owl.html

I think many in the OBO community would be confused by this "ontology" of SSSOM

@matentzn matentzn merged commit 7c06f8e into master Feb 11, 2022
@matentzn matentzn deleted the include-owl-102 branch February 11, 2022 22:05
@afk314
Copy link

afk314 commented Feb 12, 2022

Nice. One more request, can we not duplicate definitions of properties that don't belong to the SSSOM namespaces? In this file I see resources from DCT, OWL, PROV, and RDF-S merged in. I think it would be cleaner if these were imported. I'm happy to do this and commit but not certain if this is being generated from somewhere else.

@matentzn
Copy link
Collaborator

Hm, this is a very complex request, as all of these files are derived files using a framework entirely independent from SSSOM - (https://linkml.io/). If you wanted to articulate the need of separating imported entities more cleanly from internal ones, you should do it on their repo.

However, I doubt you will have much success - we have been pushing front and center to get rid of owl:imports, due to its weaknesses when it comes to tooling (network dependencies, special tools needed to load) and versioning (our imports change frequently, and it has become impossible to figure out exactly how "an ontology was at timepoint x". As this is very far beyond this issue here, you can, if you want, see this discussion here for further details on that matter:

INCATools/ontology-development-kit#194

@afk314
Copy link

afk314 commented Feb 16, 2022

OK, I understand. I suppose I haven't thought deeply enough about the topic to outright disagree with that! They are a problem to manage but I don't rely on dereferenced ontologies ever and I guess just accept all the pain. Thanks for the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants