Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mapping_source slot to Mapping #230

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Adding mapping_source slot to Mapping #230

merged 1 commit into from
Sep 23, 2022

Conversation

matentzn
Copy link
Collaborator

This was an oversight from a previous PR, we forgot to add that slot we defined to the Mapping model

Resolves [#134]

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

This is an oversight that should have been in #135.

This was an oversight from a previous PR, we forgot to add that slot we defined to the Mapping model
@hrshdhgd hrshdhgd self-requested a review September 23, 2022 13:14
@matentzn matentzn merged commit 4343f08 into master Sep 23, 2022
@matentzn matentzn deleted the adding-ms-slot branch September 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants