Make adding a concrete SSSOM example part of the new element request #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
This is much appreciated - based on the feedback I gave in #258, this will be helpful.
However, before we finish this one, can we consider how we might operationalize this? Like can we have in each field's definition a link to a list of valid SSSOM files that include the example element?
Note: I made a small cosmetic change to the table so it displays properly.
|
@cthoyt I added a commend requiring the linking of issues related to a metaelement into the linkml model itself. Sounds good? |
|
@matentzn amazing! Can we retroactively add an example that we can point to so people know how to enter something in this field correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#ISSUE, #ISSUE]
docs/have been added/updated if necessarymake testhas been run locally[Description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]