Adding QC checks for example SSSOM files #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Mar 14, 2023
| - name: Install latest SSSOM | ||
| env: | ||
| DEFAULT_BRANCH: master | ||
| run: pip install --upgrade pip && pip install -U sssom |
There was a problem hiding this comment.
should this not install SSSOM locally from the repository that's been pulled, so it can be used to test changes to the code as well? Otherwise, this PR is great.
There was a problem hiding this comment.
This requires more work, because the sssom toolkit is in a different location, and maintained differently then the stuff maintained here. We know what to do: #115
But we have not gotten around to this yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds continuous integration testing for all example SSSOM files provided in the
examplesdirectory, see also @cthoyt comments in #258.