Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues around canonical ordering #285

Merged
merged 15 commits into from
Jun 20, 2023
Merged

Issues around canonical ordering #285

merged 15 commits into from
Jun 20, 2023

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Jun 11, 2023

Partially adresses #283

  • docs/ have been added/updated if necessary

  • CHANGELOG.md has been updated.

  • Applies canonical sort ordering to all examples files

  • Downgrades the necessity of applying the canonical column order from MUST to SHOULD

  • Documents clearly that built-in prefixes MUST NOT be redefined

SHOULD/MUST fixes for canoical order
SOME filename related clarifications
BUILT in prefixes comment
@matentzn matentzn requested a review from gouttegd June 11, 2023 12:57
@matentzn matentzn marked this pull request as ready for review June 11, 2023 12:59
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but please note the remark about the SEMAPV prefix URL. The one given in the examples’ curie map differs from the one used in SEMAPV and the one registered on the bioregistry.

examples/embedded/foodie-inc-2022-05-01.sssom.tsv Outdated Show resolved Hide resolved
src/docs/spec.md Outdated Show resolved Hide resolved
src/docs/spec.md Outdated Show resolved Hide resolved
@matentzn matentzn requested a review from gouttegd June 11, 2023 14:14
@matentzn
Copy link
Collaborator Author

matentzn commented Jun 11, 2023

  • Requires a new sssom-py release @hrshdhgd (needed a sssom schema updated, which is needed by the sssom.context refresh which depends on sssom_Schema release... BRAIN TEASE). Can you keep an eye on this?

@hrshdhgd
Copy link
Contributor

@matentzn , I noticed that the qc.yml workflow here is using odkfull:v1.4 docker image. I think if you update the sssom version in the image to the latest version, this should pass. Does this make sense?

@matentzn
Copy link
Collaborator Author

@matentzn , I noticed that the qc.yml workflow here is using odkfull:v1.4 docker image. I think if you update the sssom version in the image to the latest version, this should pass. Does this make sense?

Does it make sense, instead to add a pip install -U sssom to the action to ensure its always on the most up to date state?

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Jun 20, 2023

Does it make sense, instead to add a pip install -U sssom to the action to ensure its always on the most up to date state?

I agree! That's the ideal scenario. If you mean the docker image has the most up-to-date version of sssom

@matentzn
Copy link
Collaborator Author

In this case, can you do it on this PR and see if it works?

@hrshdhgd
Copy link
Contributor

But does the Docker image already have the latest version of sssom. I made a release just yesterday.

@matentzn
Copy link
Collaborator Author

@hrshdhgd feel free to merge, its fine!

@hrshdhgd hrshdhgd merged commit 0f27603 into master Jun 20, 2023
3 checks passed
@hrshdhgd hrshdhgd deleted the change-col-order-example branch June 20, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants