Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels containing "x" mess things up mightily #28

Closed
BungaDunga opened this issue Apr 7, 2012 · 4 comments
Closed

Labels containing "x" mess things up mightily #28

BungaDunga opened this issue Apr 7, 2012 · 4 comments

Comments

@BungaDunga
Copy link

This never halts:

JSR fx
SET PC halt

:fx SET PC, POP
:halt SET PC halt

It's compiling wrong; I haven't taken the time to work out why. Naming the label anything NOT containing x works fine; if it contains x, it never stops running. I think something funny's happening...
@krasin
Copy link

krasin commented Apr 7, 2012

I confirm the issue. fx is treated as 0xF and it jumps on the zero area.

I have added this example to the test suite for DCPU16 assemblers: https://github.com/krasin/dcpu16-tests/blob/master/asm/label-fx.s

@mappum
Copy link
Owner

mappum commented Apr 7, 2012

Interesting, I will look into it when I'm at my PC.

@mappum
Copy link
Owner

mappum commented Apr 7, 2012

This issue is fixed, I guess I need to read code closer before I pull it.

@mappum mappum closed this as completed Apr 7, 2012
@krasin
Copy link

krasin commented Apr 7, 2012

Verified fix with label-fx.s test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krasin @mappum @BungaDunga