feat(UI): build base components #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapra99
commented
Nov 20, 2022
Comment on lines
+6
to
+15
| function ClientOnly({ children, fallback = null }: ClientOnlyProps) { | ||
| const [hydrated, setHydrated] = useState(() => !hydrating); | ||
|
|
||
| useEffect(function hydrate() { | ||
| hydrating = false; | ||
| setHydrated(true); | ||
| }, []); | ||
|
|
||
| return hydrated ? <>{children()}</> : <>{fallback}</>; | ||
| } |
There was a problem hiding this comment.
Remix by default will try to do an initial server rendering of all the components and deliver them to the browser, this might be a problem for some components that would depend on any browser API, which would break on the server.
This component is a HOC that will wrap these components and skip their server rendering, allowing the client to do the whole job. I haven't used it yet, but it might be useful for later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds some base components that would be used for the upcoming UI. It includes: