fix(purchase cart): dont show scrollbar if not needed #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImMPrada
reviewed
Jan 29, 2023
| @@ -7,7 +7,7 @@ const PurchaseCartModal = ({ cart, onClose, onCartRemoval }: PurchaseCartModalPr | |||
| <div className="z-50 fixed top-0 left-0 right-0 bottom-0"> | |||
| <div className="relative h-full w-full p-6 sm:px-10"> | |||
| <div className="absolute top-0 left-0 w-full h-full -z-10 bg-black opacity-40"/> | |||
| <div className="max-w-6xl mx-auto mt-20 max-h-full overflow-scroll pb-20 box-border"> | |||
| <div className="max-w-6xl mx-auto mt-20 max-h-full overflow-y-auto pb-20 box-border"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
The
overflow:scrollbehavior added to the cart list wrapper was causing the scrollbars to be permanently visible. This looks specially bad on windows.Changing the rule to
overflow-y:autofixes the issue, and makes the scrollbar appear only when the list is long enough, also this should be the behavior for y direction only