msXmpWrite(): fix use-after-free when a xmp_ metadata is using an unk…

…nown workspace
MapServer · Jul 16, 2013 · bb95b90 · bb95b90
1 parent b18cac6
commit bb95b90
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/mapxmp.c b/mapxmp.c
@@ -248,12 +248,12 @@ msXmpWrite( mapObj *map, const char *filename )
       }
       /* Or perhaps we're screwed. */
       else {
-        msFreeHashItems(&hash_ns);
-        msFree(ns_name);
-        msFree(ns_tag);
         msSetError( MS_MISCERR,
                     "Unable to identify XMP namespace '%s' in metadata key '%s'",
                     "msXmpWrite()", ns_name, key );
+        msFreeHashItems(&hash_ns);
+        msFree(ns_name);
+        msFree(ns_tag);
         return MS_FAILURE;
       }
       msFree(ns_name);