Mapfile parser doesn't error if there's remaining data after the closing END tag

[mapserver-bot]

Reporter: tbonfort
Date: 2009/03/08 - 15:11
Trac URL: http://trac.osgeo.org/mapserver/ticket/2922

MAP
 ...
 LAYER
  ...
 END
END
LAYER
 ...
END

has a closing END tag placed too early, but the mapfile parser does not error. This can be confusing as the second layer doesn't show up in the rendered map

[mapserver-bot]

Author: tbonfort
Date: 2009/03/08 - 15:12
patch to throw an error

Index: mapfile.c
===================================================================
--- mapfile.c   (revision 8648)
+++ mapfile.c   (working copy)
@@ -4739,6 +4739,11 @@
       if(map->debug == MS_NUMBER) map->debug = (int) msyynumber;
       break;
     case(END):
+      if(msyylex()!=EOF) {
+         msSetError(MS_IDENTERR, "Stray keyword (%s) (line %d) after closing END", "msLoadMap()", 
+                          msyytext, msyylineno);
+         return MS_FAILURE;
+      }
       if(msyyin) {
           fclose(msyyin);
           msyyin = NULL;

[jratike80]

Unintentionally truncated mapfiles appear quite often for me when cutting/copying/pasting parts of mapfiles. Hard to imagine any bad side effects due to this fix, so why not to make it live?

[jratike80]

Any opinions? Close as won't fix and keep on waiting that someone takes care of merging the code and making a test?