GetFeatureInfo multipart with wrong line separator

[aperi2007]

Using mapserver 6.2-dev
And asking for a GML from a getFeatureInfo request like this :

http://web.regione.toscana.it/wmsraster/com.rt.wms.RTmap/wms?map=wmscatasto&language=ita&SERVICE=WMS&VERSION=1.3.0&REQUEST=GetFeatureInfo&BBOX=1617043.371614,4810657.326353,1617576.552829,4810931.280957&CRS=EPSG:3003&WIDTH=581&HEIGHT=437&LAYERS=rt_cat.idcatbdfog.rt&STYLES=&FORMAT=image/png&QUERY_LAYERS=rt_cat.idcatbdfog.rt&FEATURE_COUNT=10&INFO_FORMAT=text/gml&I=240&J=200

The mapserver return a multipart but wronly on the two line between the two parts.
Infact seem it send a couple of LFLF instead of a couple of CRLF

As requires from specs.
http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html

So some softwares go in error and report only one part.
We are try-ing to use the apache.commons.fileupload but due to this couple LFLF they go in error with a
"malformedexception".

[aperi2007]

The patch seem to resolve only partially.
Is missing the CRLF in the headers.

I try to change directly the code to better test, and see that the changed still need are these:

In the file "mapogroutput.c"
in the line 954 apply this:

---

msIO_fprintf(stdout,"--%s\r\n",boundary );   <-- HERE

for( i = 0; file_list != NULL && file_list[i] != NULL; i++ ) {
  FILE *fp;
  int bytes_read;
  char buffer[1024];

  if( sendheaders )
    msIO_fprintf( stdout,
                  "Content-Disposition: attachment; filename=%s\r\n"   <-- HERE
                  "Content-Type: application/binary\r\n"   <-- HERE
                  "Content-Transfer-Encoding: binary%c%c%c%c",   <-- HERE
                  CPLGetFilename( file_list[i] ),
                  13,10,13,10 );   <-- HERE

---

And , still in the file "mapogroutput.c"
to the line 976

  if (file_list[i+1] == NULL)
    msIO_fprintf( stdout, "\r\n--%s--\r\n", boundary ); <-- HERE
  else
    msIO_fprintf( stdout, "\r\n--%s\r\n", boundary ); <-- HERE
}

Regards.

[aperi2007]

Hi,
I tested the changes reported and now the multipart seem to work.

I could put the new file "mapogroutput.c" in this thread, but I don't know how (if possible) to do it.

Regards.

[aperi2007]

Hi,
now the response GML from GetFeatureInfo of MapServer is ok for me.
Thx.