OGC Spatial filters fail if GEOS support not enabled

[tbonfort]

If geos support is not enabled, FLTGetSpatialComparisonCommonExpression will silently create an invalid expression as the GEOS calls it's doing will return empty strings/geometries.

[sdlime]

Sounds like an #ifdef is needed someplace.

[tbonfort]

@sdlime should all calls to FLTGetSpatialComparisonCommonExpression be ifdef'd out when GEOS is not present? The problem is that FLTGetSpatialComparisonCommonExpression and FLTGetCommonExpression return a char*, so they can't explicitely return an error code in that case.

[sdlime]

In theory the WFS capabilities should not offer certain spatial operators if GEOS is not enabled and we should throw an exception if one of those are used. We have fall backs (native MapServer) for some operators though (intersect is one example) so I don't think we can simply if-def the whole function. Wonder if we could pop something onto the error stack and return NULL? Otherwise we'd need to refactor the expressions.

[sdlime]

Pushing to 7.0... This should get cleaned up with RFC 91 since the WFS code should just author token sequences. --Steve

[msmitherdc]

these functions would still need geos is there is no spatial backend. So the if-def would have to check for the layer connection and disable if no geos for a non spatial backend.

[sdlime]

Which if-def are you referring to?

From: Michael D. Smith [mailto:notifications@github.com]
Sent: Monday, September 08, 2014 1:46 PM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] OGC Spatial filters fail if GEOS support not enabled (#4431)

these functions would still need geos is there is no spatial backend. So the if-def would have to check for the layer connection and disable if no geos for a non spatial backend.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4431#issuecomment-54867816.

[msmitherdc]

Around FLTGetSpatialComparisonCommonExpression, which this ticket was referring to. Or is this no longer an issue?

[mapserver-bot]

This is an automated comment

This issue has been closed due to lack of activity. This doesn't mean the issue is invalid, it simply got no attention within the last year. Please reopen with missing/relevant information if still valid.

Typically, issues fall in this state for one of the following reasons:

• Hard, impossible or not enough information to reproduce
• Missing test case
• Lack of a champion with interest and/or funding to address the issue