Fix python module installation with alternative root/prefix #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the other fix would be to set |
|
Looks good to me. The CMake Python variables are all named similar to |
geographika
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to package/build mapserver head before 8.0, it failed for me during install/fake, as it tried writing to the system dirs in usr/local while CMAKE_INSTALL_PREFIX and DESTDIR were properly defined - and ignored.
i think this was an oversight in the large commit done in dd310d2. Not 100% confident about all cases, but this fixes the 'install to alternate dir' problem for me. Cmake expert feedback welcome :)