New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C# bindings to work with SWIG 3.x #5583
Conversation
@geographika - have you had chance to investigate the AppVeyor issues? I assume that's more relevant to this particular issue. --Steve |
@sdlime - the issues relate to using the newer version of SWIG rather than Appveyor, so the C# interface files need changes. I've not yet been able to fix the remaining 8 issues but will have another look. Travis is passing as the C# bindings aren't built on Linux. |
Related pull request in GDAL: OSGeo/gdal#824 |
f274711
to
c07a1c8
Compare
This pull request is now complete. It does the following:
SWIG 1.3.39 was released in 2009 and has issues with generating Python3 MapScript (and possibly PHP). Nearly all changes to the CSharp MapScript interface files are to fully qualify .NET types. This is due to the following:
http://www.swig.org/Doc3.0/CSharp.html#CSharp_introduction_swig2_compatibility Only after completing the majority of these changes did I discover there is a flag to ignore these and maintain backwards compatibility:
By this stage it was as easy to complete the changes, which may make the code more future proof. .NET MapScript still compiles with SWIG 1.3.39 even with the changes in this pull request. One further issue was the following needed to be commented out:
Otherwise the following build error occurred:
|
See #5575
This initial pull request brings the number of errors when building with SWIG 3.0.12 from
1592 Error(s)
to8 Error(s)
.The remaining errors are: