Fix Equal Earth rendering for wide images #5972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects for an edge case where linear interpolation is successful for the middle point of a scanline but is incorrect for all other points. Fixes MapServer#5958
|
Why closing ? |
|
Looks like the fix works for a width of 2163 pixels but not 2560 😢 Also looks like it broke an existing test. And I assume it should been opened against |
ah ok
Not necessarily a show stopper. Would need to check if the difference is significant or not. The current results are not necessarily an absolute truth...
Indeed, the policy is now to target master, and backport if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #5958 , at least for my test case. Along the lines of @rouault 's suggested fix, the interpolation test point is taken to be just after the midpoint of the scanline. (I think this is more conservative than taking the point before the middle.) Since
msApproxTransformerbails early for scanlines with <= 5 points, the middle+1 point will always be available.