iPhone X: incorrect touch handling with cordova-plugin-statusbar

[goodsoft]

I'm submitting a ... (check one with "x")
[ ] question
[x] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS: (check one with "x")
[ ] Android
[x] iOS

cordova information: (run $> cordova plugin list)

com.googlemaps.ios 2.4.0 "Google Maps SDK for iOS"
cordova-plugin-googlemaps 2.1.1 "cordova-plugin-googlemaps"
cordova-plugin-statusbar 2.3.0 "StatusBar"

Current behavior:
When running on iPhone X simulator, map is displayed correctly, but touches are handled as if map was located 20pt higher.
That is, map plugin intercepts touches on elements just ahead of map, but doesn't react to touches on the lower 20pt strip of itself.

Expected behavior:
Touches should be handled correctly.

Related code, data or error log (please format your code or data):
Apparently, this part in src/ios/GoogleMaps/MyPluginLayer.m has hardcoded statusbar height:

    if (hasCordovaStatusBar) {
        UIApplication* app = [UIApplication sharedApplication];
        if (app.isStatusBarHidden) {
            point.y -= 20 * zoomScale;
        }
    }

Though, the behaviour of cordova-plugin-statusbar changed in these commits:
apache/cordova-plugin-statusbar@fff289c
apache/cordova-plugin-statusbar@cdc9295
apache/cordova-plugin-statusbar@c45331b

[wf9a5m75]

Please create a demo project, and share it.
And please take a screen shot.
I have no plan to buy iPhoneX. So without cooperation with yours, this issue is not able to resolved.

[goodsoft]

I don't have physical iPhone X too, but this bug can be reproduced in simulator, which is bundled with latest Xcode.
I'll create a demo project and make relevant screenshots as soon as I deal with stuff of higher priority.

In the meanwhile it's possible that someone of higher acquaintance with the code of this plugin might figure out what needs to be changed to make it work.
To help this happen I have provided exact location of relevant code and links to the commits that break it.

[wf9a5m75]

Since you don't give me any example, any screen captures, I'm not sure this commit is fixed as you want.
But the hack code should not be required anymore, because of #1875.
Please reinstall the plugin from the multiple_maps branch, and let me know the result.

[wf9a5m75]

ping

[goodsoft]

The bug is still there.
I'm trying to create a demo app to isolate this bug, but I'm not used to plain Cordova (we use rather convoluted build system), so it will take some time.

[wf9a5m75]

Well, ionic is fine. Other frameworks are fine.
And at least you can take screen record how the plugin does not work.

[wf9a5m75]

ping

[wf9a5m75]

Since there is no enough information, I close this thread.

[shrijan]

     com.googlemaps.ios 2.5.0 "Google Maps SDK for iOS"
     cordova-plugin-googlemaps 2.1.2-beta-20171120-1931 "cordova-plugin-googlemaps"
     cordova-plugin-statusbar 2.3.0 "StatusBar"

https://youtu.be/sakHY2Dycwg

Map loads fine but overlay button when tapped doesn't react but zooms the map. This happens only after cordova-plugin-statusbar installed.

[wf9a5m75]

Could you share the project files in a git repository? (bitbucket provides free private repo)

[wf9a5m75]

If you share the project files on GitHub, I will check it tomorrow. Otherwise, I will do next week.
From tomorrow, I will take US holidays in this week

[shrijan]

https://bitbucket.org/piyashrija/googlemapcordova Thanks

…

On Wed, Nov 22, 2017 at 5:41 PM, Masashi Katsumata ***@***.*** > wrote: If you share the project files on GitHub, I will check it tomorrow. Otherwise, I will do next week. From tomorrow, I will take US holidays in this week — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1874 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf9sliOlMFV91sxeyf0wDgR3LloUef6ks5s48IkgaJpZM4QanK7> .

[wf9a5m75]

Well, it's kind of too late.

[wf9a5m75]

But I will try to find a free time.

[shrijan]

Sorry Masashi, was busy yesterday. Thanks for your time.

…

On Thu, Nov 23, 2017 at 10:40 AM, Masashi Katsumata < ***@***.***> wrote: But I will try to find a free time. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1874 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf9so_E3cxozuJKoi6TLLe5tdt77eBSks5s5LDzgaJpZM4QanK7> .

[shrijan]

ping

[wf9a5m75]

I can't understand what the problem is.

[shrijan]

Problem is when you click the button on the map it will zoom map instead of action from button like I have alert text on button click. I think this is due to <preference name="StatusBarOverlaysWebView" value="false" /> if remove works but will have layout problem with iphonex Thanks

…

On Tue, Nov 28, 2017 at 8:45 AM, Masashi Katsumata ***@***.*** > wrote: I can't understand what the problem is. [image: screen shot 2017-11-27 at 1 45 02 pm] <https://user-images.githubusercontent.com/167831/33290969-3db5e2d0-d379-11e7-837a-07434cdbce58.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1874 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf9slpL5q5xwPE6h5-mjhnniIoNYaD_ks5s6y2BgaJpZM4QanK7> .

[wf9a5m75]

@shrijan Try the multiple_maps branch.

[wf9a5m75]

[shrijan]

Thank you

…

On Tue, Nov 28, 2017 at 5:00 PM, Masashi Katsumata ***@***.*** > wrote: Closed #1874 <#1874>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1874 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABf9spVzW7thoWj7fsmj65KhtP995Rn2ks5s66GDgaJpZM4QanK7> .