Fix #2871 - Resolve blank map when running compiled with latest cordova-android (which uses AGP 4.1.3) #2872

ebhsgit · 2021-05-21T07:51:26Z

From AGP 4.1.+ assert keyword/statements are enabled by the compile through code rewrite.

Which is causing PluginMap to fail

The issue is caused by PluginMap being initialised 2 times. The 2nd time it is initialised, CordovaPlugin.privateInitialize has assert to prevent this.

This PR removes initialising the PluginMap in CordovaGoogleMaps.getMap, because when it is added to PluginManager it will be initialised then.

NOTE

Although the relevant code in PluginManager and CordovaPlugin has not been changed for many years.
The plugin's codebase works for older cordova-android versions because they use older AGP.

In these older versions, assert keyword/statement do nothing

…s upgraded AGP to 4.1.3

CodeWithOz · 2021-07-26T14:32:52Z

@ebhsgit I installed from your fork and I no longer get custom map marker icons. It always uses the default red pin from Google maps. Can you please test on your end to see if you have a similar problem?

CodeWithOz · 2021-07-26T17:03:47Z

The problem was that I was using a relative path ('./www/img/myimg.png'). When I switched to the full path (${cordova.file.applicationDirectory}www/img/myimg.png) then it worked. Of course the relative path was working before I switched to this fork, so perhaps you could still check that too.

ebhsgit · 2021-07-26T23:36:17Z

@CodeWithOz

Please note my fork is not intended for production usage.

That said, there shouldn't be any changes related to map markers in the fork.

If you find the issue. Feel free to suggest a PR

kozuch · 2021-07-27T14:36:59Z

I also have the issue with blank map. Works when AGP 4.0.2 is used, but is broken with AGP 4.1.x and above.

EinfachHans · 2021-07-28T10:32:42Z

@wf9a5m75 please merge and publish a new version asap!

EinfachHans · 2021-08-04T07:09:26Z

Kinda strange, because i don't see any changes that would cause that, but i can confirm what @CodeWithOz said. My Markers that are set via url: './assets/...' doesn't work anymore with your PR 🤔

kozuch · 2021-08-04T13:11:01Z

I have not tested this fix but if it works please try to merge it so that we can use official release of this plugin and do not have to hack the solution ourselves in code. Without fix we are stuck to cordova-android@9.1.0 and can not use latest cordova-android@10.0.0 which needs Android Gradle Plugin (AGP) version 4.2.2. Thank you!

ebhsgit · 2021-08-04T23:10:39Z

There are no changes in this branch related to markers.
This pr is branched from master.

Maybe you guys are using a different branch? eg: multiple_maps, there are lots of other changes between master and multiple_maps

wf9a5m75 · 2021-08-04T23:54:15Z

Could you try the 20210804 branch?
I'm working on the next version recently, and don't touch v2.x these days. But it seems I've tried to improve something.

EinfachHans · 2021-08-05T06:30:15Z

No i'm using your branch @ebhsgit 🤔 Before i was using Version 2.7.1.

@wf9a5m75 i think this should be fixed in a hotfix 2.7.2 as it blocks the migration to cordova-android@10

EinfachHans · 2021-08-05T09:39:14Z

@wf9a5m75 i just tried to install from your branch. I got a lot of build errors, for example:

L.92: Cannot resolve symbol 'viewPlugins'
L.102: Inconvertible types; cannot cast 'org.apache.cordova.PluginEntry' to 'plugin.google.maps.PluginMarker'
L.410: Cannot resolve method 'getGoogleMap' in 'PluginMap'

in PluginMarker.java

and lots of Errors in CordovaGoogleMaps.java, which seems all be related to:

L.52: Cannot resolve symbol 'MyPluginLayout'

All in all 66 Errors

ebhsgit · 2021-08-05T11:06:38Z

@CodeWithOz
@EinfachHans

Not sure what the issue is with icons.

The changes are simple, and are definitely not related to markers.

EinfachHans · 2021-08-05T11:37:40Z

@ebhsgit give it a try yourself 😃

ebhsgit · 2021-08-05T11:38:50Z

I am not experiencing any issues with markers

EinfachHans · 2021-08-05T11:39:47Z

Do you add at least one via ./assets/...?

ebhsgit · 2021-08-05T11:40:41Z

Yup.

eg:

./assets/imgs/map/markers/start.png

EinfachHans · 2021-08-05T11:41:57Z

Do you just set the icon: './assets/imgs/map/markers/start.png' or do you set more options like size and anchor?

ebhsgit · 2021-08-05T11:42:53Z

icon: {
   url: '....',
   size: '.....'
}

EinfachHans · 2021-08-05T11:45:10Z

Strange, Version 2.7.1 works fine, but when i install from this PR directly it doesn't

wf9a5m75 · 2021-08-05T16:23:21Z

#2872 (comment)

I was able to build the plugin in ionic v5 project at least.
Did you rebuild with command ionic cordova clean then ionic cordova build android?

EinfachHans · 2021-08-05T16:25:06Z

@wf9a5m75 I completely removed the platforms, plugins, www, node_modules folder and the package_lock.json and installed and build everything from zero

EinfachHans · 2021-08-09T07:10:46Z

Okay i debugged a bit more, looks like this Marker Problem is cordova-android related: apache/cordova-android#1316 - Thanks 😊

yurik94 · 2021-10-12T01:18:43Z

Sadly still white map :(

alexp25 · 2021-10-17T10:19:58Z

It really needs to be fixed soon, because the switch to Android 11 (API Level 30) will be required by Google from 1st Nov 2021. Can the current fix be used in production at least?

alexp25 · 2021-10-17T11:26:51Z

The fix 1de03cd seemes to solve the white map issue but unfortunately, the app crashes when loading custom markers.

alexp25 · 2021-10-17T12:12:15Z

Actually, this fix by @ebhsgit seems to work with a clean install (reinstall platform and plugins, and also remove package-lock.json) 0b8ea76. With the merge commit 1de03cd I got some build errors as pointed out by @EinfachHans

sachi097 · 2021-10-20T08:48:25Z

@wf9a5m75 any timeline on when this will be merged. Many of us are waiting for the fix since switch to Android 11 (API Level 30) will be required by Google from 1st Nov 2021.

Could you please provide your thoughts upon this.

Thanks

lrobak0 · 2021-10-20T13:45:20Z

@alexp25 comment out line 1150 and 1151 (result.image.recycle(),result.image = null) in the file src/android/plugin/google/maps/PluginMarker.java then custom markers work fine

sachi097 · 2021-10-21T08:15:47Z

@alexp25 @lrobak0 can someone please help me installing commit 1de03cd

Currently I am installing via below command
cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#1de03cdb14f0239c23ac88d59ea296fa185be56e

Is this correct?

lrobak0 · 2021-10-21T08:21:14Z

I installed: https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443

sachi097 · 2021-10-21T08:33:32Z

@lrobak0 thanks for the quick response.

If I get it right you meant,
cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443

Quick questions:

Did you get any build errors post install?
Is the Map now rendering?
Did you test in production?

alexp25 · 2021-10-21T08:47:26Z

@sachi097 you can also define it in the package.json: "cordova-plugin-googlemaps": "git+https://github.com/mapsplugin/cordova-plugin-googlemaps.git#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443"

In my case, having a large project with lots of plugins, lots of features, custom markers, interactions:

The build passed
The map is rendering properly
Partially tested but not in production

lrobak0 · 2021-10-21T08:50:43Z

yes,

Did you get any build errors post install? - I musted add library com.google.android.libraries.maps:maps:3.1.0-beta in file project.properties
Yes
Did you test in production? - no

sachi097 · 2021-10-21T09:16:34Z

@alexp25 @lrobak0 thanks for your answers.

As per @lrobak0 comment installed the plugin via
cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443

Summary:

Got build errors initially, then uninstalled all the plugins and reinstalled (including https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443), deleted www folder and reinstall platform (ionic cordova platform add android@10.1.0). Post this build passed like a charm.
The map is rendering properly.
Currently, my app is in development phase. I will provide feedback once I test in production.

shajz

Tested and approved with

"cordova-android": "^10.1.1",
"cordova-plugin-androidx-adapter": "^1.1.3",
"cordova-plugin-googlemaps": "github:mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443",

Additional info for anyone struggling with the cordova-android@10 upgrade

As I'm using "cordova-plugin-geolocation": "^4.1.0",, I had to add <custom-preference delete="true" name="android-manifest/uses-feature[@android:name='android.hardware.location.gps']" /> (plugin cordova-custom-config is necessary) in my config.xml and set "cordova-plugin-geolocation": { "GPS_REQUIRED": "false" }, in my package.json. (because both plugins add this entry in AndroidManifest.xml, the build will crash. This line removes one of the two entries)
I also set <preference name="AndroidInsecureFileModeEnabled" value="true" /> as I'm still using file:// scheme internally.

@wf9a5m75 could you merge this PR and release 2.7.2 to help others migrate to cordova-android@10 ? Thanks!

ebhsgit · 2021-10-23T03:28:38Z

PR #2887 will fix the customer marker issue mentioned here with cordova-android 10+, without needing to set AndroidInsecureFileModeEnabled

adirgan · 2021-10-26T15:21:56Z

Hello everyone, do you know when you will do the merge of this PR?

cels · 2021-12-10T09:11:10Z

Are there any estimates when this will be merged?

mrbdrm · 2022-01-01T20:09:16Z

Kindly Merge

thank you for the support :)

natIs3 · 2022-03-04T10:28:35Z

Hi when can you merge this branch?

sachi097 · 2022-03-10T11:23:06Z

@alexp25 @lrobak0 thanks for your answers.

As per @lrobak0 comment installed the plugin via cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443

Summary:

Got build errors initially, then uninstalled all the plugins and reinstalled (including https://github.com/mapsplugin/cordova-plugin-googlemaps#0b8ea76ad34fb2a202a9de1b9d0e051a82ad9443), deleted www folder and reinstall platform (ionic cordova platform add android@10.1.0). Post this build passed like a charm.

The map is rendering properly.

Currently, my app is in development phase. I will provide feedback once I test in production.

Map works like charm in the production.

nosTa1337 · 2022-05-17T09:39:28Z

Any updates on merging this? Just updated my cordova to android 10 and faced this issue. Testing the PR right now.

gfranco69 · 2022-08-28T17:48:39Z

Fix #2871

From AGP 4.1.+ assert keyword/statements are enabled by the compile through code rewrite.

Which is causing PluginMap to fail

The issue is caused by PluginMap being initialised 2 times. The 2nd time it is initialised, CordovaPlugin.privateInitialize has assert to prevent this.

This PR removes initialising the PluginMap in CordovaGoogleMaps.getMap, because when it is added to PluginManager it will be initialised then.

NOTE

Although the relevant code in PluginManager and CordovaPlugin has not been changed for many years. The plugin's codebase works for older cordova-android versions because they use older AGP.

In these older versions, assert keyword/statement do nothing

Thank you , this fix Blank White Map Screen , but , now dont fire , plugin.google.maps.event.PANORAMA_READY @wf9a5m75 Any help would be appreciated.

subha-menuHuts · 2022-12-08T12:02:17Z

i have

"cordova-android": "^10.1.2",
"cordova-plugin-androidx-adapter": "^1.1.3",
"cordova-plugin-googlemaps": "^2.7.1",

google map not load display white screen

any one help me

gfranco69 · 2022-12-08T12:32:05Z

Replace these files CordovaGooleMaps PluginMap Copy here: ....\<PROJECTNAME>\platforms\android\app\src\main\java\plugin\google\maps

…

________________________________ From: subha-menuHuts ***@***.***> Sent: Thursday, December 8, 2022 8:02 AM To: mapsplugin/cordova-plugin-googlemaps ***@***.***> Cc: Guillermo Franco ***@***.***>; Comment ***@***.***> Subject: Re: [mapsplugin/cordova-plugin-googlemaps] Fix #2871 - Resolve blank map when running compiled with latest cordova-android (which uses AGP 4.1.3) (#2872) i have "cordova-android": "^10.1.2", "cordova-plugin-androidx-adapter": "^1.1.3", "cordova-plugin-googlemaps": "^2.7.1", google map not load display white screen any one help me — Reply to this email directly, view it on GitHub<#2872 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIJPNTMDXNQGLISIN27V5IDWMHE5PANCNFSM45IT6X7Q>. You are receiving this because you commented.Message ID: ***@***.***>

ebhsgit added 2 commits May 21, 2021 17:33

Fix blank map when starting app using cordova-android branch which ha…

918eb5a

…s upgraded AGP to 4.1.3

Fixed same usage pattern in other areas of the plugin

0b8ea76

kozuch mentioned this pull request Aug 4, 2021

[Android] When app is compiled with AGP 4.1.3 ('com.android.tools.build:gradle:4.1.3'), the map is blank #2871

Open

3 tasks

lempere pushed a commit to we-are-Joinup/cordova-plugin-googlemaps that referenced this pull request Sep 6, 2021

For android sdk 30, update agp, fix from: mapsplugin#2872

60f833e

shajz approved these changes Oct 22, 2021

View reviewed changes

yoneyan mentioned this pull request Aug 27, 2022

[fix] Fixed blank screen. moamoa-art/cordova-plugin-googlemaps#1

Merged

danemco mentioned this pull request Jan 25, 2024

cordova-plugin-googlemaps, map showing a blank screen. Ionic Cordova Angular #2926

Open

5 tasks

Fix #2871 - Resolve blank map when running compiled with latest cordova-android (which uses AGP 4.1.3) #2872

Are you sure you want to change the base?

Fix #2871 - Resolve blank map when running compiled with latest cordova-android (which uses AGP 4.1.3) #2872

Conversation

ebhsgit commented May 21, 2021 • edited

CodeWithOz commented Jul 26, 2021

CodeWithOz commented Jul 26, 2021 • edited

ebhsgit commented Jul 26, 2021 • edited

kozuch commented Jul 27, 2021

EinfachHans commented Jul 28, 2021

EinfachHans commented Aug 4, 2021

kozuch commented Aug 4, 2021

ebhsgit commented Aug 4, 2021

wf9a5m75 commented Aug 4, 2021

EinfachHans commented Aug 5, 2021 • edited

EinfachHans commented Aug 5, 2021

ebhsgit commented Aug 5, 2021

EinfachHans commented Aug 5, 2021

ebhsgit commented Aug 5, 2021

EinfachHans commented Aug 5, 2021

ebhsgit commented Aug 5, 2021

EinfachHans commented Aug 5, 2021

ebhsgit commented Aug 5, 2021

EinfachHans commented Aug 5, 2021

wf9a5m75 commented Aug 5, 2021

EinfachHans commented Aug 5, 2021

EinfachHans commented Aug 9, 2021

yurik94 commented Oct 12, 2021

alexp25 commented Oct 17, 2021

alexp25 commented Oct 17, 2021 • edited

alexp25 commented Oct 17, 2021 • edited

sachi097 commented Oct 20, 2021

lrobak0 commented Oct 20, 2021

sachi097 commented Oct 21, 2021

lrobak0 commented Oct 21, 2021

sachi097 commented Oct 21, 2021 • edited

alexp25 commented Oct 21, 2021 • edited

lrobak0 commented Oct 21, 2021

sachi097 commented Oct 21, 2021

shajz left a comment • edited

Choose a reason for hiding this comment

ebhsgit commented Oct 23, 2021

adirgan commented Oct 26, 2021

cels commented Dec 10, 2021

mrbdrm commented Jan 1, 2022

natIs3 commented Mar 4, 2022

sachi097 commented Mar 10, 2022

nosTa1337 commented May 17, 2022

gfranco69 commented Aug 28, 2022

subha-menuHuts commented Dec 8, 2022

gfranco69 commented Dec 8, 2022 via email

ebhsgit commented May 21, 2021 •

edited

CodeWithOz commented Jul 26, 2021 •

edited

ebhsgit commented Jul 26, 2021 •

edited

EinfachHans commented Aug 5, 2021 •

edited

alexp25 commented Oct 17, 2021 •

edited

alexp25 commented Oct 17, 2021 •

edited

sachi097 commented Oct 21, 2021 •

edited

alexp25 commented Oct 21, 2021 •

edited

shajz left a comment •

edited