Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully collapse sidebar into hamburger menu #310

Closed
jonpmarino opened this issue Dec 19, 2016 · 4 comments · Fixed by #655
Closed

Fully collapse sidebar into hamburger menu #310

jonpmarino opened this issue Dec 19, 2016 · 4 comments · Fixed by #655
Assignees

Comments

@jonpmarino
Copy link
Member

Currently, the viewer sidebar collapses to the LEFT, and partially shows. The ideal behavior is for the sidebar to fully collapse, and to be accessible by clicking the hamburger menu at top left.
screen shot 2016-12-12 at 9 44 36 am

@jonpmarino jonpmarino added this to the 0.0 Release milestone Dec 19, 2016
@jonpmarino jonpmarino removed this from the 0.0 Release milestone Jan 20, 2017
@glynnis glynnis self-assigned this Apr 20, 2017
@glynnis
Copy link
Contributor

glynnis commented Apr 20, 2017

@jonpmarino Was playing around with this in my browser and doing this would be pretty straight forward (for collapsed state):
screen shot 2017-04-20 at 4 06 58 pm

Is this what you had in mind when you said "The ideal behavior is for the sidebar to fully collapse, and to be accessible by clicking the hamburger menu at top left"? If so, one suggestion I would make would be to show some text along with or instead of an icon when the sidebar is collapsed so that the user doesn't miss the "expand" button. Depending on map content (like the default orange for polygons) or base tiles (like the geography classroom) it might be easy to miss over on the left side.

@jonpmarino
Copy link
Member Author

@glynnnis, yup that's it. I like your suggestion of text. run with it!

@jonpmarino
Copy link
Member Author

looks good on demo (May 1)

@jonpmarino
Copy link
Member Author

looks good on prod! closing.

screen shot 2017-05-10 at 5 43 43 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants