-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the @InheritConfiguration #65
Comments
@filiphr I would like to implement this feature. As far as I've seen, the following part of the documentation covers all possibilities of the requirement:
I think I can use the following test cases from the mapstruct project:
Covering all edge cases would probably result in too many code changes for you to review (or for me, it would take too much time to implement it). What do you think? What would be the main requirements to get this feature live? Also, do you think of another edge cases you can think of (or stumbled across yourself) that are important? |
You can use some of those tests cases indeed. However, as you said:
I think that we can scope it down a bit. We can skip map and iterable mappings. I think that the main requirements are the following:
We can skip the fact that found method might also have In your place I would also try to create smaller and simpler examples than the ones we have in the processor, or try to find the most basic ones we have:
|
…method and also support scenarios when using @context parameters
Let's say we have an
A
class. For it there isADto
class.We create a mapping
ADto A_to_ADto(A source)
and specify all the mappings with@Mapping
annotation.Now we want
ASpecialDto
class that extendsADto
and adds some new props that weren't mapped before.We use
@InheritConfiguration
on a new mappingASpecialDto A_to_ASpecialDto(A source)
that uses previous mapping for our needs.The plugin can't detect that we are inheriting the config and proposes to define mapping once again.
This issue may correlate with #35
The text was updated successfully, but these errors were encountered: