Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversionServiceAdapterGenerator does not respect mapstruct.suppressGeneratorTimestamp #81

Closed
freund17 opened this issue Jul 5, 2023 · 0 comments · Fixed by #82
Closed

Comments

@freund17
Copy link

freund17 commented Jul 5, 2023

The ConversionServiceAdapter generated by ConversionServiceAdapterGenerator contains a "date" value in its @Generated annotation, despite mapstruct.suppressGeneratorTimestamp=true being configured:

@Generated(
    value = "org.mapstruct.extensions.spring.converter.ConversionServiceAdapterGenerator",
    date = "2023-07-05T15:30:39.534896439Z"
)
@Component
public class ConversionServiceAdapter {
    // ...
}

It would be nice if mapstruct-spring-extensions would support this setting (or add a simular one) just like mapstruct does and render without the date attribute:

@Generated(
    value = "org.mapstruct.extensions.spring.converter.ConversionServiceAdapterGenerator"
)
@Component
public class ConversionServiceAdapter {
    // ...
}

I'm mainly thinking "reproducible builds"/"optimizing caching" here, so it would be nice that if my code didn't change, the generated output would stay the same. 🙂

Chessray added a commit that referenced this issue Jul 7, 2023
@Chessray Chessray linked a pull request Jul 7, 2023 that will close this issue
Chessray added a commit that referenced this issue Jul 7, 2023
Chessray added a commit that referenced this issue Jul 7, 2023
* Fixes #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant