(spring extension) Converters not registered.

[basven]

I used mapstruct years ago and am picking it up for this existing project I joined. I am trying something pretty basic and defined the following mappers:

@Mapper(config = MapperSpringConfig.class)
public interface TimeKeeperDtoMapper extends Converter<TimeKeeperDTO, TimeKeeper> {
    @Mapping(target = "budget", ignore = true)
    @Override
    TimeKeeper convert(@NonNull TimeKeeperDTO dto);

and another going the opposite direction:

@Mapper(config = MapperSpringConfig.class)
public interface TimeKeeperMapper extends Converter<TimeKeeper, TimeKeeperDTO> {
    @Mapping(target = "isPrimary", source = "primary")
    @Override
    @Nullable
    TimeKeeperDTO convert(@NonNull TimeKeeper entity);
}

where my config class looks as follows:

@MapperConfig(componentModel = MappingConstants.ComponentModel.SPRING, uses = LitigationConversionAdapter.class)
@SpringMapperConfig(conversionServiceAdapterClassName ="LitigationConversionAdapter", conversionServiceBeanName = "litigationConversionAdapter")
public interface MapperSpringConfig {
}

I started out with trying to inject the ConversionService into a bean but was getting a spring error that I had 2 conversion beans in my path: mvcConversionService and defaultConversionService.
I then added the Qualifier annotation to specify one of them. The problem is that for either one of them, it seems my ConversionAdapter class was not registered since calling:

conversionService.convert(TimeKeeper.builder().name("test").build(), TimeKeeperDTO.class);

always results in this exception:

org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [timeKeeper] to type [TimeKeeperDTO]
	at org.springframework.core.convert.support.GenericConversionService.handleConverterNotFound(GenericConversionService.java:322)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:195)
	at org.springframework.core.convert.support.GenericConversionService.convert(GenericConversionService.java:175)

Do I need to define some Configuration class? It must be something simple I am missing.

[filiphr]

@Chessray is this something that you might be able to help with?

[Chessray]

Could you tell us a bit more about the project setup? A standard Spring Boot project typically picks this up out of the box. @basven Just to clarify: From Spring's point of view, everything is registered as a Bean, but depending on your setup you might need to add the converters to the conversion service separately. See the tests for examples of that.

[basven]

This project uses spring boot 2.7.6 but I noticed it also pulled in a dependency on spring cloud. I don't think it needs that so i will see what happens when I remove that. I will also look at those tests you mentioned, I missed that.

…

On Sat, Jul 29, 2023, 10:31 Raimund Klein ***@***.***> wrote: Could you tell us a bit more about the project setup? A standard Spring Boot project typically picks this up out of the box. @basven <https://github.com/basven> Just to clarify: From Spring's point of view, everything is registered as a Bean, but depending on your setup you might need to add the converters to the conversion service separately. See the tests for examples <https://github.com/mapstruct/mapstruct-spring-extensions/blob/main/examples/noconfig/src/test/java/org/mapstruct/extensions/spring/example/ConversionServiceAdapterIntegrationTest.java> of that. — Reply to this email directly, view it on GitHub <#3336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAROFYMK6R6NCSEQ2QJLC6DXSU3EJANCNFSM6AAAAAA2O5EFQM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Chessray]

Most Spring Boot projects will configure automatically. But AFAIR this requires the web module. If your project doesn't use that, I recommend looking at this example.

[basven]

Pretty sure we have the web starter dependency

…

On Sat, Jul 29, 2023, 13:53 Raimund Klein ***@***.***> wrote: Most Spring Boot projects will configure automatically. But AFAIR this requires the web module. If your project doesn't use that, I recommend looking at this <https://github.com/mapstruct/mapstruct-spring-extensions/blob/main/examples/simple-springboot/src/main/java/org/mapstruct/extensions/spring/example/boot/config/ConverterConfig.java> example. — Reply to this email directly, view it on GitHub <#3336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAROFYKCYYXWMRM2WXRJXP3XSVS3JANCNFSM6AAAAAA2O5EFQM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[filiphr]

Thanks @Chessray for looking into this. @basven if it doesn't work like @Chessray explained then please provide us a minimal reproducible example that we can try out.

[Chessray]

One more thing that strikes me as very unusual is that you mentioned having two ConversionService beans in your application context. I can imagine this might confuse the whole setup. You may want to explore that angle as well. In any case, please let us know the outcome. This may result in some type of change to the extension.

[basven]

Apologies for the delayed response; slammed at work and in the middle of moving. Anyhow, I created a small test project and as soon as I add the below dependency I am getting the NoUniqueBeanDefinition exception. Removing it and it just works.

<dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-starter-data-rest</artifactId>
</dependency>

Note that when I remove the above dependency but add @EnableWebMvc to my application, I see the same exception again.

Moving forward, I will take a look at the examples on how to register the converters to the service.

[Chessray]

Thanks. So combining various default starters can actually result in multiple ConversionServices being in the ApplicationContext. I guess at the very least that would call for an option to specify a bean name at the injection point inside the adapter class. Of course, it still wouldn't solve the auto-registration of the individual Converters. In any case, this has brought up something to work on for the extension project.

[Chessray]

I just realized that we at least provide the option of specifying the bean name already: https://mapstruct.org/documentation/spring-extensions/reference/html/#customConversionService

Since I never used this feature myself, I'm unsure as to whether there's an elegant way to register the individual Converters with one of several ConversionServices automatically. If @dmham86 is still around: Are you able to give a detailed explanation?

[basven]

This worked for me. Defined a bean in my main app like this:

    @Bean("mapStructConversionService")
    ConfigurableConversionService getConversionService(PersonMapper personMapper) {
        DefaultConversionService service = new DefaultConversionService();
        service.addConverter(personMapper);
        return service;
    }

Inject and test it:

@SpringBootTest
public class MapperTest {

    @Inject
    @Qualifier("mapStructConversionService")
    private ConversionService conversionService;

    @Test
    public void test(){
        Person p = new Person(1, "test");
        PersonDTO dto = conversionService.convert(p, PersonDTO.class);
        assertNotNull(dto);
        assertEquals(p.getId(), dto.getId());
        assertEquals(p.getName(), dto.getName());

    }
}

Of course the registration might become a nightmare when there are a lot of converters.

[basven]

The better solution is the one @Chessray suggested later, which is this one
Thanks for all the help.