Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for new JDK 8 date/time types #121

Closed
gunnarmorling opened this issue Feb 2, 2014 · 9 comments
Closed

Provide support for new JDK 8 date/time types #121

gunnarmorling opened this issue Feb 2, 2014 · 9 comments
Labels
Milestone

Comments

@gunnarmorling
Copy link
Member

Conversions to/from String and legacy date types

@gunnarmorling gunnarmorling added this to the 1.0.0.Beta2 milestone Mar 12, 2014
@timoe
Copy link

timoe commented May 8, 2014

Hey @gunnarmorling. As this is similar to Joda integration I would like to do this one and Issue #145 too.

@gunnarmorling
Copy link
Member Author

@timoe That's awesome; Just assigned it to you.

@gunnarmorling
Copy link
Member Author

@timoe Hey, are you still interested in contributing this feature?

@timoe
Copy link

timoe commented Jul 3, 2014

Hey Gunnar. I am. Back from vacation I´m going to do it this week

@timoe
Copy link

timoe commented Jul 4, 2014

Hey Gunnar,

do you have any hint how to integrate the changes I did on the "processor" module for integration java 8 date & time. Should that be done similar to "core" and "core-jdk8" modules?
If you take a look at my last commit there are no runtime dependency to new date and time types but only test deps.

@agudian
Copy link
Member

agudian commented Jul 4, 2014

Test deps should be OK, as we need to build with JDK8 anyway... 😉

@timoe
Copy link

timoe commented Jul 5, 2014

ok, so you haven´t done any magic with mavens toolchains :-P

agudian pushed a commit to agudian/mapstruct that referenced this issue Jul 29, 2014
agudian pushed a commit to agudian/mapstruct that referenced this issue Jul 29, 2014
agudian added a commit to agudian/mapstruct that referenced this issue Jul 29, 2014
@gunnarmorling
Copy link
Member Author

@agudian, @timoe: That's done already, right? I guess only the doc update is missing?

@gunnarmorling gunnarmorling modified the milestones: 1.0.0.RC1, 1.0.0.Beta3 Nov 25, 2014
@gunnarmorling
Copy link
Member Author

I guess only the doc update is missing?

Ah, no, that's already done as well on the Beta3 doc branch. Thanks, @timoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants