Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage documentation examples use obsolete net.ltgt.apt plugin for Gradle #2346

Closed
mjustin opened this issue Jan 30, 2021 · 1 comment · Fixed by #2349
Closed

Usage documentation examples use obsolete net.ltgt.apt plugin for Gradle #2346

mjustin opened this issue Jan 30, 2021 · 1 comment · Fixed by #2349
Milestone

Comments

@mjustin
Copy link

mjustin commented Jan 30, 2021

The Gradle documentation in the reference guide and project readme both instruct the reader to use the net.ltgt.apt plugin. However, this plugin has declared itself obsolete as of Gradle 5.2:

The goal of this plugin was to eventually no longer be needed, being superseded by built-in features.
This has become a reality with Gradle 5.2 and IntelliJ IDEA 2019.1. tl;dr: this plugin is obsolete, don't use it. If you're using Eclipse though, continue reading.
[...]
If you're using Eclipse, please migrate to the com.diffplug.eclipse.apt plugin, which is a (maintained) fork of net.ltgt.apt-eclipse.

In short, unless Eclipse is being used, you can use the built-in Gradle annotation processing functionality. If Eclipse is being used, it looks like the com.diffplug.eclipse.apt plugin should be used instead.

Therefore, the documentation should be updated to use the built-in Gradle annotation processor support, rather than the obsolete plugin.

@filiphr
Copy link
Member

filiphr commented Jan 30, 2021

Thanks for pointing this out. We are going to update the documentation and readme for this.

@filiphr filiphr added this to the 1.4.2 milestone Jan 30, 2021
filiphr added a commit to filiphr/mapstruct that referenced this issue Jan 30, 2021
…adle

Remove obsolete net.ltgt.apt
Use com.diffplug.eclipse.apt for Eclipse
IntelliJ works transparently
filiphr added a commit that referenced this issue Jan 31, 2021
Remove obsolete net.ltgt.apt
Use com.diffplug.eclipse.apt for Eclipse
IntelliJ works transparently
filiphr added a commit to filiphr/mapstruct that referenced this issue Jan 31, 2021
…adle

Remove obsolete net.ltgt.apt
Use com.diffplug.eclipse.apt for Eclipse
IntelliJ works transparently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants