Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve line location report for invalid qualifier for SubclassMapping #3202

Closed
filiphr opened this issue Mar 17, 2023 · 1 comment · Fixed by #3204
Closed

Improve line location report for invalid qualifier for SubclassMapping #3202

filiphr opened this issue Mar 17, 2023 · 1 comment · Fixed by #3204
Labels
enhancement good first issue
Milestone
1.6.0.Beta1

Comments

@filiphr
Copy link
Member

filiphr commented Mar 17, 2023

In PR #3120 we added support for qualifiedBy and qualifiedByName. Our generic logic seems like it is putting the error line location on the method element itself. We should instead use the @SubclassMapping element for reporting the error.

This issue is a good issue to get started with MapStruct. If the original creator of the PR @EvaristeGalois11 is not interested in adding this, then I would invite someone from the community to give it a go.
@filiphr filiphr mentioned this issue Mar 17, 2023
Merged
@EvaristeGalois11
Copy link
Contributor

Yep no problem, i'll give it a try! 🚀

EvaristeGalois11 added a commit to EvaristeGalois11/mapstruct that referenced this issue Mar 18, 2023
@EvaristeGalois11
mapstruct#3202 Improve line location report for invalid qualifier for…
feaf190 
… SubclassMapping
@EvaristeGalois11 EvaristeGalois11 mentioned this issue Mar 18, 2023
Merged
@filiphr filiphr added this to the 1.6.0 milestone Apr 16, 2023
EvaristeGalois11 added a commit to EvaristeGalois11/mapstruct that referenced this issue Apr 16, 2023
@EvaristeGalois11
mapstruct#3202 Improve line location report for invalid qualifier for…
d989a9d 
… SubclassMapping
filiphr pushed a commit that referenced this issue Apr 22, 2023
@EvaristeGalois11 @filiphr
#3202 Improve line location report for invalid qualifier for Subclass…
b1034e6 
…Mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
1.6.0.Beta1
Development

Successfully merging a pull request may close this issue.

Improve line location report for invalid qualifier for SubclassMapping EvaristeGalois11/mapstruct
2 participants
@filiphr @EvaristeGalois11