Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1359 Collection target should be considered as immutable if there is no read accessor #1412

Merged
merged 1 commit into from Apr 8, 2018
Merged

#1359 Collection target should be considered as immutable if there is no read accessor #1412

merged 1 commit into from Apr 8, 2018

Conversation

filiphr
Copy link
Member

@filiphr filiphr commented Apr 2, 2018

Fixes #1359.

We need to consider a collection target as immutable if there is no read accessor for it

sjaakd
sjaakd approved these changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@sjaakd sjaakd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this issue introduced due to the builder?

@filiphr
Copy link
Member Author

filiphr commented Apr 8, 2018

was this issue introduced due to the builder?

Not really it was always there. However, I noticed it at work when I was using builders for updates

@filiphr filiphr merged commit 42d7bfe into mapstruct:master Apr 8, 2018
@filiphr filiphr deleted the 1359 branch April 8, 2018 13:27
@filiphr
Copy link
Member Author

filiphr commented Apr 8, 2018

Thanks for the review @sjaakd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaakd sjaakd sjaakd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filiphr @sjaakd