#1180 non existing (nested) property in shared config #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiphr
requested changes
May 8, 2018
| * @author Filip Hrisafov | ||
| */ | ||
| @Mapper( config = SharedConfig.class ) | ||
| public abstract class SourceTargetMapper { |
There was a problem hiding this comment.
Can you name this ErroneousIssue1180Mapper or just ignore this mapper in the FullFeatureTest, so the integration tests pass
|
@filiphr .. integration test passing now.. |
filiphr
approved these changes
May 8, 2018
|
thanks for reviewing @filiphr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally found the issue. Although the added null check might perhaps not be the good solution.
Fixes #1180