Fix exception in pmtiles format when GeoJSON is requested #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acalcutt
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Tested the changes and they fixed the error.
Without this change geojson gave the error
file:///C:/Users/acalcutt/Documents/GitHub/tileserver-gl-maptiler/src/serve_data.js:73
if (isGzipped) {
^
ReferenceError: isGzipped is not defined
at file:///C:/Users/acalcutt/Documents/GitHub/tileserver-gl-maptiler/src/serve_data.js:73:15
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exception when format
pmtilesis used andGeoJSONis requested. Here the variableisGzippedis always undefined and the check is redundant because the data is already unzipped. See #1187.