Add transform to make population an integer #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarianski
force-pushed
the
population-integer
branch
from
742c27b
to
d480875
Compare
| @@ -389,6 +389,14 @@ def place_ne_capital(shape, properties, fid, zoom): | |||
| return shape, properties, fid | |||
|
|
|||
|
|
|||
| def place_population_int(shape, properties, fid, zoom): | |||
| population_str = properties.get('population') | |||
There was a problem hiding this comment.
Do we want to pop the population property so that if the parsing fails we don't leave a str property?
There was a problem hiding this comment.
Good call. Updated in ef91c10
|
👍 looks good to me! |
rmarianski
added a commit
that referenced
this pull request
Dec 1, 2015
Add transform to make population an integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: tilezen/vector-datasource#230
Connects with: tilezen/vector-datasource#416
@zerebubuth: could you review please?