Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the splash screen #14

Merged
merged 9 commits into from
May 30, 2019
Merged

Fix the splash screen #14

merged 9 commits into from
May 30, 2019

Conversation

harry6396
Copy link

@harry6396 harry6396 commented May 29, 2019 •
edited
Loading

  1. Fixed the type of the variable to retain the progress of the extraction
  2. Updated the background of the splash screen.
  3. Updated the initial count of the coin.
  4. Updated the package name of SeaWorld

@harry6396 harry6396 self-assigned this May 29, 2019
@harry6396 harry6396 added the enhancement New feature or request label May 29, 2019
@harry6396 harry6396 added this to In progress in PehlaSchool via automation May 29, 2019
@harry6396 harry6396 changed the title Fixed the splash screen #2 Fixed the splash screen May 29, 2019
@harry6396 harry6396 changed the title #2 Fixed the splash screen Fixed the splash screen May 30, 2019
ankitk20
ankitk20 requested changes May 30, 2019
View reviewed changes
kitkitschoollogger/kitkitlogger/build.gradle Outdated Show resolved Hide resolved
library/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
mainapp/proj.android-studio/app/src/utils/Zip.java Outdated Show resolved Hide resolved
seaworld/proj.android-studio/app/build.gradle Outdated Show resolved Hide resolved
seaworld/proj.android-studio/app/build.gradle Outdated Show resolved Hide resolved
PehlaSchool automation moved this from In progress to Review in progress May 30, 2019
PehlaSchool automation moved this from Review in progress to Reviewer approved May 30, 2019
@harry6396 harry6396 changed the title Fixed the splash screen Fixe the splash screen May 30, 2019
@harry6396 harry6396 changed the title Fixe the splash screen Fix the splash screen May 30, 2019
@harry6396 harry6396 merged commit 8aa9ec3 into newmaster May 30, 2019
PehlaSchool automation moved this from Reviewer approved to Done May 30, 2019
@akashdabhi03 akashdabhi03 deleted the PrabhatT/FixSplashScreenProgress branch July 15, 2019 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitk20 ankitk20 ankitk20 approved these changes

@akashdabhi03 akashdabhi03 akashdabhi03 approved these changes

@mathewnik90 mathewnik90 Awaiting requested review from mathewnik90

Assignees

@harry6396 harry6396

Labels
enhancement New feature or request
Projects
PehlaSchool
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harry6396 @ankitk20 @akashdabhi03