Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run litmus test suite on travis #44

Merged
merged 1 commit into from Oct 9, 2016
Merged

Run litmus test suite on travis #44

merged 1 commit into from Oct 9, 2016

Conversation

pokoli
Copy link
Contributor

@pokoli pokoli commented Oct 7, 2016

I noticed that litmus is failing on the master branch but we did not notice which changeset broke it as travis is not executing the litmus test suite.

So I'm adding a script to install litmus and modified the .travis.yml file in order to run it before running the test.

@tomviner
Copy link
Contributor

tomviner commented Oct 7, 2016

@pokoli regarding the test fail, see how to allow sudo usage on travis: https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

@pokoli
Copy link
Contributor Author

pokoli commented Oct 8, 2016

@tomviner thanks for your feedback!

@pokoli
Copy link
Contributor Author

pokoli commented Oct 8, 2016

Ok, so everything is good now, the build is failing because the litmus test suite is not passing.

I thank that the litmus test suite must be fixed before merging this PR.

@mar10
Copy link
Owner

mar10 commented Oct 8, 2016

The third test seems to fail because litmus is not configured for SSL support:

  1. begin................. FAIL (No SSL support, reconfigure using --with-ssl)

@pokoli
Copy link
Contributor Author

pokoli commented Oct 9, 2016

@mar10 thanks for the input. Travis is green now, let met know if you want me to rebase (and squash) this PR before merging.

Copy link
Contributor

@tomviner tomviner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably makes sense to squash the commits.

@@ -0,0 +1,6 @@
#/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hash bang doesn't have a bang (!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for review and fixing

@pokoli
Copy link
Contributor Author

pokoli commented Oct 9, 2016

I rebased all the commits into a single one.

@mar10 mar10 merged commit ee22961 into mar10:master Oct 9, 2016
@mar10
Copy link
Owner

mar10 commented Oct 9, 2016

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants