Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HttpRequest command #78 #79

Merged
merged 1 commit into from
Sep 26, 2022
Merged

add HttpRequest command #78 #79

merged 1 commit into from
Sep 26, 2022

Conversation

leo-schick
Copy link
Member

See #78

@leo-schick leo-schick marked this pull request as ready for review May 23, 2022 12:57
@leo-schick leo-schick requested a review from jankatins May 23, 2022 12:57
@@ -84,5 +85,30 @@ def quote(s):
+ '"'


def http_request_command(url: str, headers: {str: str} = None, method: str = 'GET', body: str = None, body_from_stdin: bool = False) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could get some tests

Copy link
Member

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, some tests would be nice, but ...

@leo-schick leo-schick changed the base branch from 3.3.x to main September 26, 2022 09:57
@leo-schick leo-schick merged commit 5b1d91d into main Sep 26, 2022
@leo-schick leo-schick deleted the add-http-request-command branch February 24, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants