Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_user_display_name on docker #90

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Conversation

leo-schick
Copy link
Member

On docker the flask mara_pipelines.ui.run-interactively fails with
image

This is a fix for this: According to the python documentation os.getlogin(), getpass.getuser() should be used.

@leo-schick leo-schick added the bug Something isn't working label Jan 25, 2023
@jankatins
Copy link
Member

Does that work in the end in the environment where os.getlogin() failed?

Copy link
Member

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also wrap it in a try/except in case this ends up with the same problem? Haven't looks into what getuser does internally...

@leo-schick
Copy link
Member Author

Done.

@leo-schick leo-schick merged commit 405352f into main Jan 31, 2023
@leo-schick leo-schick deleted the fix-docker-interactive-run branch January 31, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants