Change all functions to return Message and error. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable a workflow I need, where an API can receive a message from a client, add a job into a queue, then return the ID of the job to the client. This is useful for allowing the client to request updates on the progress of that job. When implementing this, it was necessary to shared the Message and ID structs, so I moved them into the "common" dir. I had not envisaged so many changes when I started, but the change to function signatures cascaded throughout much of the codebase. I'm new to Go, so if this is not idiomatic I'm happy to collaborate on further changes.
|
Hi @austinjp, thank you for wanting to contribute! 😊 I'd like to understand your use case a bit better. Is this with the pure message queue or the new job runner abstraction? Could you describe what you'd like to monitor? |
|
Hi there. Slight side-track: last night after opening this PR, I noticed your contributor guidelines. As they recommend, I've opened issue #42 to discuss my use case. You're welcome to close this or leave it open as you prefer, until/if the use case makes sense to you! |
|
Closing this -- it contains a design flaw (a.k.a. bug!) -- the 'common' dir is inside the 'internal' dir, making it inaccessible. See ongoing conversation elsewhere about how this feature might best be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Many thanks for goqite, it's just what I was looking for 😄
This PR is to enable a workflow I need, where an API can receive a message from a client, add a job into a queue, then return the ID of the job to the client. The client could then (for example) request updates on the progress of that job.
When implementing this, it was necessary to shared the Message and ID structs, so I moved them into the "common" dir.
I had not envisaged so many changes when I started, but the change to function signatures cascaded throughout much of the codebase.
All tests have been updated and all pass, but I'm new to Go so if the code is not idiomatic I'm happy to collaborate on further changes.