Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch tabindex rule #13

Merged
merged 1 commit into from May 20, 2019
Merged

fix: patch tabindex rule #13

merged 1 commit into from May 20, 2019

Conversation

sawa-zen
Copy link
Contributor

@sawa-zen sawa-zen commented May 17, 2019

I fixed error in tabindex-no-positive. #12 could not consider v-if.
Please review again 馃檱

鈫揺rror

 1) tabindex-no-positive valid <template><span v-if="true" tabindex="0"></span></template>:
    TypeError: Cannot read property 'name' of null
     at EventEmitter.VAttribute (lib/rules/tabindex-no-positive.js:28:40)

patch #12
fixed #7

@maranran maranran merged commit 70c91ac into maranran:master May 20, 2019
@sawa-zen sawa-zen deleted the fix/tabindex branch July 2, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaxListenersExceededWarning
2 participants