-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket timeout causes process to crash #345
Comments
So, being a noob to rxjs I didn't know about the GlobalConfig that has an onUnhandledError property that you can set with a function to handle the error (see below). Handling the error prevents the process from crashing. Anyway, I still don't understand what is timing out but the error seems to not be indicative of bigger problems as once handled the process stays up and keeps working as expected. I will leave this issue open until the library author has a chance to give any insight... import { config } from 'rxjs'
config.onUnhandledError = console.error |
@matthewpflueger what client you use for connecting with websocket server? Does it handle heartbeat? Maybe there is a BTW. this is the only place in the |
@JozefFlakus I am using WebSocket King to connect and no, I don't think it is handling the heartbeat. If that is the cause then this is likely a non-issue as in production the client will handle the heartbeat. FYI switched to marblejs@next in order to have "official" rxjs 7 support and so far so good! |
@matthewpflueger did you notice any mentioned problems so far with the nightly build? 🤔 |
Nope! So far I haven't run into this issue again... |
Ok, I'll keep it open till the official release of v4.0. |
Is there any workaround/solution for this issue in v3? I'm experiencing the same issue and I think I won't be able to upgrade to v4 before production release... Just a quick observation, maybe it helps to analyze the issue - I'm using websockets for front-end - back-end communication and this error occurs almost every time when the front-end application runs in iOS browser (regardless it's Safari, Chrome, ....) |
I've little bit investigated it... I suppose Reproduction info:
|
@jan-kacina version |
@jan-kacina fix is here. Will release it under |
|
Describe the bug
Following the documentation, I setup a basic hello world http and websocket server (code below). Running the code works fine but after some time of inactivity a TimeoutError is thrown which kills the entire process. This seems like unexpected behavior. Is that correct? Anyway to prevent/catch the TimeoutError?
To Reproduce
Compile and run the code below. Send a hello message then walk away. After some time the following exception occurs killing the process:
The code:
Expected behavior
A TimeoutError should not kill the process and/or there should be a way to catch and handle this error.
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: