Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Logger #212

Merged
merged 1 commit into from Jan 16, 2020
Merged

feat(core): Logger #212

merged 1 commit into from Jan 16, 2020

Conversation

JozefFlakus
Copy link
Member

@JozefFlakus JozefFlakus commented Jan 15, 2020

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • @marblejs/core - composable Logger dependency
  • @marblejs/core - log all relevant #createServer actions, like (registered dependencies, mapped effects, etc.)
  • @marblejs/middleware-logger - refactor + reuse core Logger
  • @marblejs/middleware-logger - removed deprecated loggerWithOpts$
  • @marblejs/middleware-logger - removed writeToStream options since the streaming can be added to registered custom Logger dependency
  • @marblejs/core - removed root @marblejs/core/dist/+internal index.ts file - since it could cause circular dependency problems

Zrzut ekranu 2020-01-15 o 20 10 09

Does this PR introduce a breaking change?

[x] Yes
[ ] No

@JozefFlakus JozefFlakus added enhancement New feature or request scope: core Relates to @marblejs/core package labels Jan 15, 2020
@JozefFlakus JozefFlakus added this to the 3.0 milestone Jan 15, 2020
@JozefFlakus JozefFlakus self-assigned this Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #212 into next will decrease coverage by 0.93%.
The diff coverage is 84.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #212      +/-   ##
==========================================
- Coverage   96.56%   95.62%   -0.94%     
==========================================
  Files         131      135       +4     
  Lines        2099     2151      +52     
  Branches      285      288       +3     
==========================================
+ Hits         2027     2057      +30     
- Misses         70       91      +21     
- Partials        2        3       +1
Impacted Files Coverage Δ
packages/websockets/src/server/websocket.server.ts 100% <100%> (ø) ⬆️
packages/middleware-logger/src/index.ts 100% <100%> (ø) ⬆️
packages/middleware-cors/src/util.ts 87.5% <100%> (ø) ⬆️
...ackages/middleware-logger/src/logger.middleware.ts 100% <100%> (ø) ⬆️
...ore/src/http/response/http.responseBody.factory.ts 100% <100%> (ø) ⬆️
packages/core/src/logger/logger.token.ts 100% <100%> (ø)
.../http/response/http.responseContentType.factory.ts 100% <100%> (ø) ⬆️
packages/core/src/logger/logger.interface.ts 100% <100%> (ø)
...ages/websockets/src/error/websocket.error.model.ts 100% <100%> (ø) ⬆️
packages/middleware-logger/src/logger.util.ts 100% <100%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a0f93...62acbf5. Read the comment docs.

@JozefFlakus JozefFlakus force-pushed the feat/core/logger branch 4 times, most recently from da7bdf5 to 34949a8 Compare January 15, 2020 21:22
@JozefFlakus JozefFlakus merged commit 964ea8d into next Jan 16, 2020
@JozefFlakus JozefFlakus deleted the feat/core/logger branch January 16, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: core Relates to @marblejs/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant