Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): router resolver - malformed URI error handling #310

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

JozefFlakus
Copy link
Member

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #309

What is the new behavior?

  • @marblejs/core - In case of malformed url error, instead of crashing the whole server it keeps running stable and returns a Bad-Request error.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #310 (e62a937) into master (cbdffda) will increase coverage by 0.24%.
The diff coverage is 96.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   95.41%   95.66%   +0.24%     
==========================================
  Files         157      163       +6     
  Lines        2769     3090     +321     
  Branches      366      427      +61     
==========================================
+ Hits         2642     2956     +314     
- Misses        123      129       +6     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/core/src/context/context.hook.ts 100.00% <ø> (ø)
...ackages/core/src/effects/effectsContext.factory.ts 100.00% <ø> (ø)
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/messaging/src/reply/reply.ts 100.00% <ø> (ø)
...rc/transport/strategies/amqp.strategy.interface.ts 81.81% <ø> (ø)
.../testing/src/testBed/http/http.testBed.response.ts 75.00% <40.00%> (-13.24%) ⬇️
packages/core/src/+internal/utils/string.util.ts 92.00% <66.66%> (-8.00%) ⬇️
packages/core/src/+internal/utils/any.util.ts 84.61% <71.42%> (+1.28%) ⬆️
...ore/src/http/response/http.responseBody.factory.ts 80.95% <73.33%> (-19.05%) ⬇️
...ssaging/src/transport/strategies/local.strategy.ts 92.15% <83.33%> (+4.92%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e827898...e62a937. Read the comment docs.

@JozefFlakus JozefFlakus merged commit eec7b48 into master Jan 5, 2021
@JozefFlakus JozefFlakus deleted the fix/309/malformed-uri branch January 5, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URIError: URI malformed exception crashes server for named route parameters
1 participant