-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to modify style of map boundaries + interface language #3
Comments
Hi there, Thanks a lot, I'm delighted to hear kids are playing with it! Please let me know if you have any issues navigating around the code base or sending the update. The translations are located in the folder The styles for the map division are located in Have a good weekend |
Thanks a lot for your quick reply! I had already forked your project and I think I have correctly edited those files:
But I couldn't actually test my changes, because my javascript and github experience is quite poor and I couldn't see my changes running on github pages, like your demo. Last night I followed the github pages instructions but at the beginning I only get the readme page ... I didn't know how to access the game itself, like in the top right link in your repository. I don't think this is related, but your "about" says "Implemented using React+Redux", but I have no idea of how those work and if I need to install them somehow to my forked repo. Also, I don't exactly know how to submit my translation files to you "the proper git way" (never used github in a collaborative way, other than commenting things and submitting issues). Thanks a lot again |
Correct, the About the changes, the standard way of working would be to send a "pull request" to the origin repository to bring the improvements. Then I would simply merge your code changes to the repository and the game would be automatically updated. In order to test the changes, you should run a local server, simply run Happy to help! |
Mmm, so you mean testing my changes using a node server, right? But the demo you provide runs on github-pages. Sorry about my ignorance |
Yes, the application was developed first locally using a Node server, then published to github-pages. There is no reason to apologies for something you don't know :) |
I have made two translated UI files: Thanks for the explanations. I think learning React and Node will be too much for the time I can spend on this, so it would be impossible for me to change the boundary style. But if you are going to update my translations and republish, I suggest you to take the opportunity and try some other different boundary styles (red, thick, blinking or whatever). Another option would be using a random semi-transparent fill colour for every country, so they are easier to visually separate from their neighbours. |
Fantastic, thanks for the translations. |
So fast and so good! Perfect! |
You're very welcome, I'll close this ticket. |
Hi there
Veeeeery cool game!!
It works nicely on my tablet, except for one thing: it is very hard to me to see boundaries when I zoom in.
I more or less know where to look for some small countries, but I can't zoom to the exact zone before the timeout because I can't see their boundaries.
If you could tell me which file I need to modify, I would change their style to a thick red line.
Also, I like a lot to have so many languages available,
But these only change the topographic names. The game interface remains in English.
I want my non-english kids to use it, so I would translate it to their language myself.
Is there a language config file where I can easily change the game interface?
Thanks a lot for your help
The text was updated successfully, but these errors were encountered: