Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues are not rendered on iOS due to Buffer not being available #9

Closed
marcus-crane opened this issue May 3, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@marcus-crane
Copy link

Hi there,

I use this plugin on my desktop but I also use Obsidian on mobile and presumably the mobile version doesn't have access to a module that is available on desktop.

From memory, Buffer is part of the Node standard library so perhaps there needs to be a polyfill for the mobile version.

I haven't done much with Obsidian plugins yet but I know enough about Node that I'm happy to try and debug this myself and file a PR 🙂

60A3F8FD-20A3-4F77-A835-E002498A91CD

@marcus-crane
Copy link
Author

Took me a bit to figure out how to test this stuff on mobile (I used https://github.com/TfTHacker/obsidian42-brat) but I got a fix working that I've PRed 🙂

@marcus-crane
Copy link
Author

The plugin works really well on mobile after this fix. I reduced the table to 3 columns (that's all I care about) which is about the maximum size the non-responsive table can get before it's as wide as the screen. The issue there is just that the whole page overflow out of the viewport instead of the table being forced into a scrollable state.

@marc0l92
Copy link
Owner

marc0l92 commented May 5, 2022

I implemented the fix in version 1.11.0
Please test it and let me know your feedbacks.

I will also test a bit more the UI on mobile in order to implement an horizontal scrolling

@marc0l92 marc0l92 self-assigned this May 5, 2022
@marc0l92 marc0l92 added the bug Something isn't working label May 5, 2022
@marcus-crane
Copy link
Author

Just updated the plugin on mobile and yep, it continues to work just as you'd expect so marking this issue as closed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants