Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rotate effect #113

Merged
merged 9 commits into from Mar 19, 2023
Merged

feat: Rotate effect #113

merged 9 commits into from Mar 19, 2023

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Mar 12, 2023

Closes #114

  • I need to properly pass the transformed matrix to each element's child

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 27.27% and project coverage change: -0.13 ⚠️

Comparison is base (6688c63) 43.51% compared to head (8ccf49d) 43.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   43.51%   43.39%   -0.13%     
==========================================
  Files          75       76       +1     
  Lines        5740     5791      +51     
==========================================
+ Hits         2498     2513      +15     
- Misses       3242     3278      +36     
Impacted Files Coverage Δ
elements/src/lib.rs 31.25% <ø> (ø)
renderer/src/renderer.rs 0.00% <0.00%> (ø)
renderer/src/window.rs 0.00% <0.00%> (ø)
state/src/lib.rs 26.41% <ø> (ø)
state/src/transform.rs 60.00% <60.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marc2332 marc2332 mentioned this pull request Mar 14, 2023
2 tasks
@marc2332 marc2332 marked this pull request as ready for review March 17, 2023 20:19
@marc2332 marc2332 changed the title feat: Experimental rotate effect feat: Rotate effect Mar 17, 2023
@marc2332 marc2332 merged commit f0f82a0 into main Mar 19, 2023
@marc2332 marc2332 deleted the feat/transform-rotate branch May 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: rotate effect
1 participant