Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qplayvid.c compile errors: get_buffer2, av_frame_get_best_effort_timestamp #18

Open
kamalmostafa opened this issue Apr 13, 2014 · 2 comments

Comments

@kamalmostafa
Copy link
Contributor

Commit 3fd071e "Update qplayvid to newer ffmpeg APIs" breaks the build for all systems which supply ffmpeg/libav versions < 56 (i.e. practically all current systems!) ...

qplayvid.c: In function ‘decode_audio’:
qplayvid.c:140:18: error: ‘AVCodecContext’ has no member named ‘get_buffer2’
  ctx->a_codec_ctx->get_buffer2(ctx->a_codec_ctx, ctx->a_frame, 0);
                  ^
qplayvid.c: In function ‘decode_video’:
qplayvid.c:225:2: warning: implicit declaration of function ‘av_frame_get_best_effort_timestamp’ [-Wimplicit-function-declaration]
  frame_pts = av_frame_get_best_effort_timestamp(ctx->v_frame);
  ^
make[2]: *** [tools/qplayvid/CMakeFiles/qplayvid.dir/qplayvid.c.o] Error 1
make[1]: *** [tools/qplayvid/CMakeFiles/qplayvid.dir/all] Error 2
make: *** [all] Error 2

My pending pull request #17 now includes this patch to unbreak it:
Commit 12574cb "Fix qplayvid build for older ffmpeg APIs".

@ottobonn
Copy link

This fix is needed to build on Ubuntu 14.04 / Mint 17. Any chance this will be merged soon?

@replica3363
Copy link

I thank you very much kamalmostafa, I use Ubuntu 14.04. After a (long) fight for dependencies, the last but not the least qplayvid.c.o refused compilation. I was lost, your commits 3fd071e & 12574cb saved my night at 2:30 AM local french time !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants