Fix Data.new to accept let positional parameters than needed.

Add missing test [Fixes #187]
marcandre · Apr 5, 2023 · 498910c · 498910c
1 parent ea97f3e
commit 498910c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/lib/backports/3.2.0/data.rb b/lib/backports/3.2.0/data.rb
@@ -50,15 +50,10 @@ def self.members       #   def self.members
       class << klass
         def new(*values, **named_values)
           if named_values.empty?
-            case values.size <=> members.size
-            when -1
-              missing = members[values.size..-1].map(:inspect).join(", ")
-              raise ArgumentError, "Missing keywords: #{missing}"
-            when +1
+            if values.size > members.size
               raise ArgumentError, "wrong number of arguments (given #{values.size}, expected 0..#{members.size})"
-            when 0
-              super(**members.zip(values).to_h)
             end
+            super(**members.first(values.size).zip(values).to_h)
           else
             unless values.empty?
               raise ArgumentError, "wrong number of arguments (given #{values.size}, expected 0)"

diff --git a/test/data_test.rb b/test/data_test.rb
@@ -97,6 +97,7 @@ def initialize(*args, **kwargs)
 
     # Missing arguments can be fixed in initialize
     assert_equal([[], {foo: 1}], klass.new(foo: 1).passed)
+    assert_equal([[], {foo: 42}], klass.new(42).passed)
 
     # Extra keyword arguments can be dropped in initialize
     assert_equal([[], {foo: 1, bar: 2, baz: 3}], klass.new(foo: 1, bar: 2, baz: 3).passed)