Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript types #11

Closed

Conversation

mentos1386
Copy link

Fixes #10

@@ -0,0 +1,9 @@
import type { MeterProvider } from "@opentelemetry/api-metrics";

declare module "opentelemetry-node-metrics" {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope i did this right. I have never written a d.ts file before.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't be jsdoc annotations already good enough for this simple use case?

@mentos1386 mentos1386 closed this Apr 3, 2023
@mentos1386 mentos1386 deleted the feat-add-typescript-types branch April 3, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript type support
2 participants