Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add a feature to disable the required fields #10

Closed
ellemaker opened this issue Aug 3, 2021 · 9 comments
Closed

Can you add a feature to disable the required fields #10

ellemaker opened this issue Aug 3, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@ellemaker
Copy link

No description provided.

@marcbelletre marcbelletre added the question Further information is requested label Aug 3, 2021
@marcbelletre
Copy link
Owner

What do you mean? The only required field is the start date. We can't make it optional otherwise the plugin can't work.

@ellemaker
Copy link
Author

yes, because I have an event that will not have recurring dates. can it be done if the start date is set up then the plugin will work?

@marcbelletre
Copy link
Owner

Oh okay I see. I'll have a look at it tomorrow. In the meantime you can add conditional logic on your RRule field based on a true/false field. This will bypass the validation.

@marcbelletre marcbelletre added enhancement New feature or request and removed question Further information is requested labels Aug 3, 2021
@ellemaker
Copy link
Author

I already done this but it won't submit or publish the post

@marcbelletre
Copy link
Owner

I just tested out and it can confirm that it works. What version of ACF and ACF RRule are you using?

Here the validation fails when I check the box and leave the field empty:
Capture d’écran 2021-08-04 à 09 15 20

But it works when I uncheck it:
Capture d’écran 2021-08-04 à 09 15 27

@ellemaker
Copy link
Author

ellemaker commented Aug 4, 2021

ACF PRo : Version 5.9.9
RRule : Version 1.2.1

Screenshot_43

this is what you mean right?

@ellemaker
Copy link
Author

Try it on custom post type without a content/editor field

@marcbelletre
Copy link
Owner

Hi @ellemaker,

I just released a new version with improved validation. This includes the possibility to disable required fields as requested. If you don't make RRule field as required then nothing will be saved unless you specify a start date.

@ellemaker
Copy link
Author

@marcbelletre thank you 🥳🥳🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants