-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go version, unify errors and other refactoring #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taniabogatsch
changed the title
Uniform errors and other refactoring
Bump Go version, unify errors and other refactoring
Mar 20, 2024
marcboeker
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring and centralized errors. I've added some minor comments.
taniabogatsch
force-pushed
the
unify-errors
branch
from
March 21, 2024 10:13
50b87e6
to
67b8589
Compare
It looks like our
|
taniabogatsch
force-pushed
the
unify-errors
branch
from
March 21, 2024 12:14
e71fb35
to
dfd5ab0
Compare
Thanks for the modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New error functions
This PR adds a new file,
errors.go
, which unifies driver error messages by introducing two new functions:getError
andgetDuckDBError
. For now, I've only used the new error functions induckdb.go
, but if this is a sensible proposal, I'll open more PRs to unify errors throughout the driver.Other changes
@marcboeker, let me know what you think. :)
con *C.duckdb_connection
becomesduckdbConn C.duckdb_connection
, as it already is a pointer.conn
toconnection
, to avoid shadowing when using the variable nameconn
.